Skip to content

Bump go version to 1.26.0#300

Merged
ahrtr merged 1 commit intoetcd-io:mainfrom
henrybear327:go/1.26.0
Mar 5, 2026
Merged

Bump go version to 1.26.0#300
ahrtr merged 1 commit intoetcd-io:mainfrom
henrybear327:go/1.26.0

Conversation

@henrybear327
Copy link
Copy Markdown
Contributor

@henrybear327 henrybear327 commented Mar 3, 2026

@henrybear327 henrybear327 self-assigned this Mar 3, 2026
@henrybear327 henrybear327 requested a review from ahrtr March 3, 2026 20:05
@henrybear327
Copy link
Copy Markdown
Contributor Author

henrybear327 commented Mar 3, 2026

/retest

ivanvc
ivanvc reviewed Mar 4, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @henrybear327. Could you please restore the toolchain directive? I'm unsure if the failure is because of that.

@ivanvc ivanvc mentioned this pull request Mar 4, 2026
Closed
18 tasks
@henrybear327
Copy link
Copy Markdown
Contributor Author

henrybear327 commented Mar 4, 2026

Thanks, @henrybear327. Could you please restore the toolchain directive? I'm unsure if the failure is because of that.

Let me try.

It's go mod tidy that automatically removed the toolchain directive ;(

@henrybear327
Bump go version to 1.26.0
c158086 
Reference:
- etcd-io/etcd#21364

Signed-off-by: Chun-Hung Tseng <henrytseng@google.com>
@ahrtr
Copy link
Copy Markdown
Member

ahrtr commented Mar 4, 2026

/ok-to-test

ahrtr
ahrtr approved these changes Mar 4, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @ivanvc

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Mar 4, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, henrybear327

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ivanvc
Copy link
Copy Markdown
Member

ivanvc commented Mar 4, 2026

Can we consolidate this and #301? I don't see the need for two different PRs.

@ahrtr
Copy link
Copy Markdown
Member

ahrtr commented Mar 5, 2026

Can we consolidate this and #301? I don't see the need for two different PRs.

I agree. But not a big problem, let's just merge both PRs.

@ahrtr ahrtr merged commit b43b3ee into etcd-io:main Mar 5, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ivanvc ivanvc ivanvc left review comments

@ahrtr ahrtr ahrtr approved these changes

Assignees

@henrybear327 henrybear327

Labels

approved ok-to-test size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@henrybear327 @ahrtr @k8s-ci-robot @ivanvc