feat: add Helm Chart support with auto-generation from Kustomize#231
Open
ballista01 wants to merge 1 commit intoetcd-io:mainfrom
Open
feat: add Helm Chart support with auto-generation from Kustomize#231ballista01 wants to merge 1 commit intoetcd-io:mainfrom
ballista01 wants to merge 1 commit intoetcd-io:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ballista01 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
ff91da2 to
67be641
Compare
2ee081b to
786d7e7
Compare
Member
Author
7845c57 to
8d64111
Compare
Signed-off-by: Wenxue Zhao <ballista01@outlook.com>
8d64111 to
a88f78b
Compare
Member
|
I did briefly review this. I believe it should be broken down into at least separate commits. Also, the README.md appears to point to another chart. I'll come back to this after 0.2.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired by #95 (comment) I tried to add a Helm Chart support for etcd-operator. The Chart is auto-generated from Kustomize manifests to maintain a single source of truth.
Changes
Helm Chart Generation
make helmgenerates Chart from Kustomize using helmify and yqhelm lintvalidationDeployment Methods
DEPLOY_METHODenv var: "kustomize", "helm", or "all" (default)Documentation
Testing
Architecture
Breaking Changes
None. Existing Kustomize deployments work unchanged.
Closes #94