api: add EtcdCluster status fields and CRD schema#229
Merged
ahrtr merged 1 commit intoetcd-io:mainfrom Oct 28, 2025
Merged
Conversation
Member
Author
|
/ok-to-test |
Member
Author
Member
|
Link to #182 |
ivanvc
reviewed
Oct 26, 2025
Member
ivanvc
left a comment
ivanvc
left a comment
There was a problem hiding this comment.
This matches what's in #182. I left only a suggestion. Thanks, @ballista01
api/v1alpha1/etcdcluster_types.go
Outdated
Comment on lines
+159
to
+161
| // LeaderId is the hex-encoded ID of the current etcd cluster leader, if one exists and is known. | ||
| // +optional | ||
| LeaderId string `json:"leaderId,omitempty"` |
Member
There was a problem hiding this comment.
Can we rename this to LeaderID to match the Go standard?
Suggested change
| // LeaderId is the hex-encoded ID of the current etcd cluster leader, if one exists and is known. | |
| // +optional | |
| LeaderId string `json:"leaderId,omitempty"` | |
| // LeaderID is the hex-encoded ID of the current etcd cluster leader, if one exists and is known. | |
| // +optional | |
| LeaderID string `json:"leaderID,omitempty"` |
Member
Author
There was a problem hiding this comment.
Yeah, it also matches what's in etcdutils.go. Thanks for the suggestion! Applied.
Signed-off-by: Wenxue Zhao <ballista01@outlook.com>
ballista01
force-pushed
the
status-api
branch
from
c257926 to
921dff0
Compare
Member
Member
|
Thanks @ballista01 for the contribution! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, ballista01, ivanvc The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #136 for easier review per #136 (comment). API Changes only, no logic.