implement nationalities system / added countries.json#1746
Open
SNAILX808 wants to merge 11 commits intoesx-framework:devfrom
Open
implement nationalities system / added countries.json#1746SNAILX808 wants to merge 11 commits intoesx-framework:devfrom
SNAILX808 wants to merge 11 commits intoesx-framework:devfrom
Conversation
Zuntie
reviewed
Oct 23, 2025
|
|
||
| RegisterNUICallback("ready", function(_, cb) | ||
| ready = true | ||
| SendNUIMessage({ type = "config", data = Config }) |
There was a problem hiding this comment.
Use the
cbparam to send the data. So something likecb({ data = Config })No need to have another event sending the config, unnecessary.
Yep, that's a good idea. Thank you very much! Slipped my mind.
Zykem
requested changes
Oct 23, 2025
|
|
||
| RegisterNUICallback("ready", function(_, cb) | ||
| ready = true | ||
| SendNUIMessage({ type = "config", data = Config }) |
Contributor
There was a problem hiding this comment.
Use the cb param to send the data. So something like cb({ data = Config }) No need to have another event sending the config, unnecessary.
Zykem
reviewed
Oct 23, 2025
Zykem
reviewed
Oct 23, 2025
Zuntie
reviewed
Oct 23, 2025
feat(es_extended): add xPlayer.updatePlayerData
- setNationality func to set the nationality and used updatePlayerData to sync the nationality on the client-side - getNationality func to return nationality as string value - removed the parts that use state bag
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
implemented nationalities system
Implementation Details
Usage Example
PR Checklist