Skip to content

feat: add extraEnv for httpbingo chart #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
plumdog wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add extraEnv for httpbingo chart #143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/httpbingo/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: httpbingo
description: A reasonably complete and well-tested golang port of httpbin, with zero dependencies outside the go stdlib.
type: application
version: 0.1.1
version: 0.2.0
appVersion: "v2.2.2"
home: https://github.com/estahn/charts/tree/main/charts/httpbingo
keywords:
Expand Down
1 change: 1 addition & 0 deletions charts/httpbingo/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ A reasonably complete and well-tested golang port of httpbin, with zero dependen
| image.repository | string | `"mccutchen/go-httpbin"` | |
| image.tag | string | `""` | |
| imagePullSecrets | list | `[]` | |
| extraEnv | object | `{}` | See https://github.com/mccutchen/go-httpbin#configuration |
| ingress.annotations | object | `{}` | |
| ingress.className | string | `""` | |
| ingress.enabled | bool | `false` | |
Expand Down
7 changes: 7 additions & 0 deletions charts/httpbingo/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,13 @@ spec:
{{- toYaml .Values.securityContext | nindent 12 }}
image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}"
imagePullPolicy: {{ .Values.image.pullPolicy }}
{{- with .Values.extraEnv }}
env:
{{- range $name, $value := . }}
- name: {{ $name }}
value: {{ $value | quote }}
{{- end }}
{{- end }}
ports:
- name: http
containerPort: 8080
Expand Down
3 changes: 3 additions & 0 deletions charts/httpbingo/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@ image:
# Overrides the image tag whose default is the chart appVersion.
tag: ""

# See https://github.com/mccutchen/go-httpbin#configuration
extraEnv: {}

imagePullSecrets: []
nameOverride: ""
fullnameOverride: ""
Expand Down