Add DLT statistics native-ui with chart#2477
Merged
AmmarAbouZor merged 2 commits intoesrlabs:native-uifrom Feb 10, 2026
Merged
Conversation
kruss
force-pushed
the
native-ui-dlt-statistics-with-chart
branch
from
f7bfb98 to
d5ec8cb
Compare
kruss
force-pushed
the
native-ui-dlt-statistics-with-chart
branch
from
d5ec8cb to
be1afd6
Compare
AmmarAbouZor
reviewed
Feb 5, 2026
Member
AmmarAbouZor
left a comment
AmmarAbouZor
left a comment
There was a problem hiding this comment.
I've looked into it quickly, really nice 🙌
I have small comments for now, I'll get back to this soon and give a proper review once the cleanup is done
application/apps/indexer/gui/application/src/host/ui/session_setup/main_config/dlt.rs
Outdated
Show resolved
Hide resolved
AmmarAbouZor
requested changes
Feb 8, 2026
Member
AmmarAbouZor
left a comment
AmmarAbouZor
left a comment
There was a problem hiding this comment.
Wow this is one huge feature with a clean implementation and problems solving.
I went deep in this second review and found some really interesting points and pitfalls and tried to explain them with details
application/apps/indexer/gui/application/src/host/ui/session_setup/state/parsers/dlt.rs
Outdated
Show resolved
Hide resolved
application/apps/indexer/gui/application/src/host/ui/session_setup/state/parsers/dlt.rs
Outdated
Show resolved
Hide resolved
application/apps/indexer/gui/application/src/host/ui/session_setup/state/parsers/dlt.rs
Outdated
Show resolved
Hide resolved
application/apps/indexer/gui/application/src/host/service/mod.rs
Outdated
Show resolved
Hide resolved
application/apps/indexer/gui/application/src/host/service/mod.rs
Outdated
Show resolved
Hide resolved
application/apps/indexer/gui/application/src/host/ui/session_setup/main_config/dlt.rs
Show resolved
Hide resolved
kruss
force-pushed
the
native-ui-dlt-statistics-with-chart
branch
5 times, most recently
from
9e12ab3 to
c69c297
Compare
kruss
force-pushed
the
native-ui-dlt-statistics-with-chart
branch
from
c69c297 to
7429b6e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.