Skip to content

Improve waLBerla integration#5225

Merged
kodiakhq[bot] merged 2 commits intoespressomd:pythonfrom
jngrad:walberla_api
Jan 9, 2026
Merged

Improve waLBerla integration#5225
kodiakhq[bot] merged 2 commits intoespressomd:pythonfrom
jngrad:walberla_api

Conversation

@jngrad
Copy link
Copy Markdown
Member

@jngrad jngrad commented Jan 7, 2026 •
edited
Loading

Fixes #5224

Description of changes:

  • synchronize ESPResSo and waLBerla MPI Cartesian communicators
  • remove waLBerla's dependency on ESPResSo global variables that will be removed in the future
  • remove workarounds in the Python integration of waLBerla and roll out the System::Leaf pattern
  • decouple checkpointing of the global state (MPI Cartesian communicators) from ESPResSo objects

jngrad added 2 commits January 8, 2026 20:04
@jngrad
Roll out Leaf API in the waLBerla code
751bd81
@jngrad
Improve MPI Cartesian communicators management
2423b02 
Synchronize ESPResSo and waLBerla MPI Cartesian communicators.
Avoid node_grid reset when reloading a System object from a
checkpoint file.
@jngrad jngrad changed the title waLBerla API change Improve waLBerla integration Jan 9, 2026
@jngrad jngrad added Core ScriptInterface waLBerla Issues regarding waLBerla integration CodeQuality labels Jan 9, 2026
@jngrad jngrad marked this pull request as ready for review January 9, 2026 00:59
@jngrad jngrad requested a review from hidekb January 9, 2026 01:02
hidekb
hidekb approved these changes Jan 9, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@hidekb hidekb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jngrad jngrad added the automerge Merge with kodiak label Jan 9, 2026
@kodiakhq kodiakhq Bot merged commit f74e2d5 into espressomd:python Jan 9, 2026
11 checks passed
@jngrad jngrad deleted the walberla_api branch January 9, 2026 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hidekb hidekb hidekb approved these changes

Assignees

No one assigned

Labels

automerge Merge with kodiak CodeQuality Core ScriptInterface waLBerla Issues regarding waLBerla integration

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ESPResSo and waLBerla MPI Cartesian communicators can disagree

2 participants

@jngrad @hidekb