Skip to content

Conversation

@jakub-kocka
Copy link
Collaborator

@jakub-kocka jakub-kocka commented Jan 26, 2026

Description

  • Added/Fixed unit tests and made them automatically run on PR
  • Added installation tests for built wheels before upload to Espressif's PyPI

Related

  • internal tracker: IDF-14066

Testing

Unit tests: https://github.com/espressif/idf-python-wheels/actions/runs/21480882896/job/61876690271?pr=58
Action run platforms-dispatch: TBD
Action run defined-wheel: TBD


Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

@jakub-kocka jakub-kocka self-assigned this Jan 26, 2026
@github-actions
Copy link

github-actions bot commented Jan 26, 2026

Messages
📖 You might consider squashing your 4 commits (simplifying branch history).

👋 Hello jakub-kocka, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Addressing info messages (📖) is strongly recommended; they're less critical but valuable.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 8e040fe

@jakub-kocka jakub-kocka force-pushed the feat/added_tests branch 2 times, most recently from 022e58d to d660b51 Compare January 29, 2026 08:03
@jakub-kocka jakub-kocka marked this pull request as draft January 29, 2026 13:22
@jakub-kocka jakub-kocka force-pushed the feat/added_tests branch 3 times, most recently from 4cadb14 to ad9410e Compare January 29, 2026 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants