Skip to content

Conversation

@facchinm
Copy link
Contributor

@facchinm facchinm commented Dec 5, 2025

We noticed that adding the expander code in the core has been a bad idea 🙃
Moving it out to https://github.com/arduino-libraries/Arduino_Nesso_N1 , while leaving here only an explicit error message (much more informative than just failing at link time).

@ubidefeo
@me-no-dev

@facchinm facchinm requested a review from P-R-O-C-H-Y as a code owner December 5, 2025 15:13
@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2025

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "nesso_n1: move expander and battery to external library":
    • type/action should be one of [change, ci, docs, feat, fix, refactor, remove, revert, test]

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 10 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

👋 Hello facchinm, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against fcd14ea

@SuGlider SuGlider added Type: 3rd party Boards Related to third-party/non-Espressif hardware boards. Status: Review needed Issue or PR is awaiting review labels Dec 5, 2025
@SuGlider SuGlider added this to the 3.3.0 milestone Dec 5, 2025
@SuGlider SuGlider moved this from Todo to In Progress in Arduino ESP32 Core Project Roadmap Dec 5, 2025
@SuGlider SuGlider moved this from In Progress to In Review in Arduino ESP32 Core Project Roadmap Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Review needed Issue or PR is awaiting review Type: 3rd party Boards Related to third-party/non-Espressif hardware boards.

Projects

Status: In Review

Development

Successfully merging this pull request may close these issues.

5 participants