feat(matter): adds temperature controlled cabinet ep #12104

SuGlider · 2025-12-04T18:52:51Z

Description of Change

Adds a new Matter endpoint for Temperature Controlled Cabinet with related documentation and examples.

Test Scenarios

CI
Provided examples

Related links

none

github-actions · 2025-12-04T18:53:29Z

	Warnings
⚠️	Some issues found for the commit messages in this PR: the commit message `"fix(matter): bad content in source file"`: body's lines must not be longer than 100 characters the commit message `"fix(matter): typo"`: summary looks too short the commit message `"fix(matter): typo"`: summary looks too short the commit message `"fix(matter): typo"`: summary looks too short the commit message `"fix(matter): typo"`: summary looks too short the commit message `"fix(matter): typo"`: summary looks too short the commit message `"fix(matter): typo"`: summary looks too short Please fix these commit messages - here are some basic tips: follow Conventional Commits style correct format of commit message should be: `<type/action>(<scope/component>): <summary>`, for example `fix(esp32): Fixed startup timeout issue` allowed types are: `change,ci,docs,feat,fix,refactor,remove,revert,test` sufficiently descriptive message summary should be between 10 to 72 characters and start with upper case letter avoid Jira references in commit messages (unavailable/irrelevant for our customers) `TIP:` Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

	Messages
📖	This PR seems to be quite large (total lines of code: 2045), you might consider splitting it into smaller PRs

👋 Hello SuGlider, we appreciate your contribution to this project!

📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...

This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- Addressing info messages (📖) is strongly recommended; they're less critical but valuable.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...

We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 9fae46d

Copilot

Pull request overview

This PR adds a new Matter endpoint MatterTemperatureControlledCabinet that implements the Matter temperature control standard for managing temperature-controlled appliances like refrigerators, freezers, and wine coolers. The implementation supports two mutually exclusive operating modes: temperature_number (precise setpoint control with min/max/step) and temperature_level (preset-based control with supported levels array).

Key changes:

New endpoint class with dual-mode initialization supporting both temperature setpoint and temperature level control
Comprehensive examples demonstrating both operating modes with dynamic temperature updates
Complete API documentation including usage examples and integration guides

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
MatterTemperatureControlledCabinet.h	Header file defining the endpoint class with dual-mode API (temperature_number and temperature_level)
MatterTemperatureControlledCabinet.cpp	Implementation with attribute management, validation, and custom endpoint for temperature_level mode
Matter.h	Added include and friend class declaration for the new endpoint
keywords.txt	Added new API keywords and fixed duplicate onChangeMode entry
CMakeLists.txt	Added source file to build configuration
MatterTemperatureControlledCabinet example	Demonstrates temperature_number mode with dynamic setpoint cycling
MatterTemperatureControlledCabinetLevels example	Demonstrates temperature_level mode with dynamic level cycling
README.md files	Comprehensive setup and usage documentation for both examples
ep_temperature_controlled_cabinet.rst	Complete API reference documentation with examples
matter.rst	Added endpoint to documentation index

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

...amples/MatterTemperatureControlledCabinetLevels/MatterTemperatureControlledCabinetLevels.ino

libraries/Matter/src/MatterEndpoints/MatterTemperatureControlledCabinet.cpp

libraries/Matter/src/MatterEndpoints/MatterTemperatureControlledCabinet.h

...es/Matter/examples/MatterTemperatureControlledCabinet/MatterTemperatureControlledCabinet.ino

...amples/MatterTemperatureControlledCabinetLevels/MatterTemperatureControlledCabinetLevels.ino

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

github-actions · 2025-12-04T19:36:57Z

Test Results

83 files 83 suites 25m 56s ⏱️
55 tests 55 ✅ 0 💤 0 ❌
598 runs 598 ✅ 0 💤 0 ❌

Results for commit 9fae46d.

♻️ This comment has been updated with latest results.

github-actions · 2025-12-04T19:40:08Z

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

Memory	FLASH [bytes]		FLASH [%]		RAM [bytes]		RAM [%]
Target	DEC	INC	DEC	INC	DEC	INC	DEC	INC
ESP32C5	0	0	0.00	0.00	0	0	0.00	0.00
ESP32S3	0	⚠️ +672	0.00	⚠️ +0.04	0	0	0.00	0.00
ESP32S2	0	⚠️ +672	0.00	⚠️ +0.04	0	0	0.00	0.00
ESP32C3	0	0	0.00	0.00	0	0	0.00	0.00
ESP32C6	0	0	0.00	0.00	0	0	0.00	0.00
ESP32H2	0	0	0.00	0.00	0	0	0.00	0.00
ESP32	0	⚠️ +672	0.00	⚠️ +0.04	0	0	0.00	0.00

Click to expand the detailed deltas report [usage change in BYTES]

Target	ESP32C5		ESP32S3		ESP32S2		ESP32C3		ESP32C6		ESP32H2		ESP32
Example	FLASH	RAM	FLASH	RAM	FLASH	RAM	FLASH	RAM	FLASH	RAM	FLASH	RAM	FLASH	RAM
libraries/Matter/examples/MatterColorLight	0	0	⚠️ +672	0	⚠️ +672	0	0	0	0	0	0	0	⚠️ +672	0
libraries/Matter/examples/MatterCommissionTest	0	0	⚠️ +672	0	⚠️ +672	0	0	0	0	0	0	0	⚠️ +672	0
libraries/Matter/examples/MatterComposedLights	0	0	⚠️ +672	0	⚠️ +672	0	0	0	0	0	0	0	⚠️ +672	0
libraries/Matter/examples/MatterContactSensor	0	0	⚠️ +672	0	⚠️ +672	0	0	0	0	0	0	0	⚠️ +672	0
libraries/Matter/examples/MatterDimmableLight	0	0	⚠️ +672	0	⚠️ +672	0	0	0	0	0	0	0	⚠️ +672	0
libraries/Matter/examples/MatterEnhancedColorLight	0	0	⚠️ +672	0	⚠️ +672	0	0	0	0	0	0	0	⚠️ +672	0
libraries/Matter/examples/MatterEvents	0	0	⚠️ +672	0	⚠️ +672	0	0	0	0	0	0	0	⚠️ +672	0
libraries/Matter/examples/MatterFan	0	0	⚠️ +672	0	⚠️ +672	0	0	0	0	0	0	0	⚠️ +672	0
libraries/Matter/examples/MatterHumiditySensor	0	0	⚠️ +672	0	⚠️ +672	0	0	0	0	0	0	0	⚠️ +672	0
libraries/Matter/examples/MatterLambdaSingleCallbackManyEPs	0	0	⚠️ +672	0	⚠️ +672	0	0	0	0	0	0	0	⚠️ +672	0
libraries/Matter/examples/MatterMinimum	0	0	⚠️ +672	0	⚠️ +672	0	0	0	0	0	0	0	⚠️ +672	0
libraries/Matter/examples/MatterOccupancySensor	0	0	⚠️ +672	0	⚠️ +672	0	0	0	0	0	0	0	⚠️ +672	0
libraries/Matter/examples/MatterOnIdentify	0	0	⚠️ +672	0	⚠️ +672	0	0	0	0	0	0	0	⚠️ +672	0
libraries/Matter/examples/MatterOnOffLight	0	0	⚠️ +672	0	⚠️ +672	0	0	0	0	0	0	0	⚠️ +672	0
libraries/Matter/examples/MatterOnOffPlugin	0	0	⚠️ +672	0	⚠️ +672	0	0	0	0	0	0	0	⚠️ +672	0
libraries/Matter/examples/MatterPressureSensor	0	0	⚠️ +672	0	⚠️ +672	0	0	0	0	0	0	0	⚠️ +672	0
libraries/Matter/examples/MatterRainSensor	0	0	⚠️ +672	0	⚠️ +672	0	0	0	0	0	0	0	⚠️ +672	0
libraries/Matter/examples/MatterSmartButton	0	0	⚠️ +672	0	⚠️ +672	0	0	0	0	0	0	0	⚠️ +672	0
libraries/Matter/examples/MatterTemperatureControlledCabinet	-	-	-	-	-	-	-	-	-	-	-	-	-	-
libraries/Matter/examples/MatterTemperatureControlledCabinetLevels	-	-	-	-	-	-	-	-	-	-	-	-	-	-
libraries/Matter/examples/MatterTemperatureLight	0	0	⚠️ +672	0	⚠️ +672	0	0	0	0	0	0	0	⚠️ +672	0
libraries/Matter/examples/MatterTemperatureSensor	0	0	⚠️ +672	0	⚠️ +672	0	0	0	0	0	0	0	⚠️ +672	0
libraries/Matter/examples/MatterThermostat	0	0	⚠️ +672	0	⚠️ +672	0	0	0	0	0	0	0	⚠️ +672	0
libraries/Matter/examples/MatterWaterFreezeDetector	0	0	⚠️ +672	0	⚠️ +672	0	0	0	0	0	0	0	⚠️ +672	0
libraries/Matter/examples/MatterWaterLeakDetector	0	0	⚠️ +672	0	⚠️ +672	0	0	0	0	0	0	0	⚠️ +672	0

Copilot

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 7 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

libraries/Matter/examples/MatterTemperatureControlledCabinetLevels/README.md

libraries/Matter/examples/MatterTemperatureControlledCabinet/README.md

libraries/Matter/src/MatterEndpoints/MatterTemperatureControlledCabinet.cpp

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

docs/en/matter/ep_temperature_controlled_cabinet.rst

Reinstate important note about mutually exclusive features for temperature control modes.

Refactor MatterTemperatureControlledCabinet to support both temperature_number and temperature_level features. Introduce new methods for handling temperature levels and update existing methods to accommodate the new structure.

SuGlider added 3 commits December 4, 2025 13:50

feat(matter): adds temperature controlled cabinet matter endpoint

51d1bd8

feat(matter): fixes step attibute issue from esp-matter

657d118

feat(matter): organize examples, keywords and fix init error

132e752

SuGlider added this to the 3.3.0 milestone Dec 4, 2025

SuGlider self-assigned this Dec 4, 2025

SuGlider added the Area: Matter Issues and Feature Request about Matter Protocol label Dec 4, 2025

SuGlider requested a review from lucasssvaz as a code owner December 4, 2025 18:52

SuGlider added this to Arduino ESP32 Core Project Roadmap Dec 4, 2025

SuGlider requested review from me-no-dev and pedrominatel as code owners December 4, 2025 18:52

github-project-automation bot moved this to Todo in Arduino ESP32 Core Project Roadmap Dec 4, 2025

SuGlider moved this from Todo to In Progress in Arduino ESP32 Core Project Roadmap Dec 4, 2025

SuGlider requested review from P-R-O-C-H-Y and Copilot December 4, 2025 18:53

Copilot started reviewing on behalf of SuGlider December 4, 2025 18:53 View session

Copilot finished reviewing on behalf of SuGlider December 4, 2025 18:57

Copilot AI reviewed Dec 4, 2025

View reviewed changes

SuGlider and others added 2 commits December 4, 2025 16:05

fix(matter): typo

390140c

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

fix(matter): typo

59bc50c

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

SuGlider marked this pull request as draft December 4, 2025 19:06

SuGlider and others added 5 commits December 4, 2025 16:15

fix(matter): improves commentaries

73c9f72

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

fix(matter): typo

9d9255e

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

fix(matter): typo

38f04b8

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

feat(matter): checks level to verify that it is valid

d2b2060

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

feat(matter): checks level to verify that it is valid

988ea97

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

SuGlider requested a review from Copilot December 4, 2025 19:46

Copilot started reviewing on behalf of SuGlider December 4, 2025 19:47 View session

Copilot finished reviewing on behalf of SuGlider December 4, 2025 19:48

SuGlider added the Status: Review needed Issue or PR is awaiting review label Dec 4, 2025

fix(matter_docs): rst formatting

786d1b7

SuGlider marked this pull request as ready for review December 4, 2025 19:51

SuGlider changed the title ~~Feat/matter temperature controlled cabinet ep~~ feat(matter): adds temperature controlled cabinet ep Dec 4, 2025

Copilot AI reviewed Dec 4, 2025

View reviewed changes

SuGlider and others added 6 commits December 4, 2025 17:28

fix(matter): typo

3c9d3b4

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

fix(matter): typo

daad7dc

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

fix(matter): removes redundant code

f4a0ac1

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

fix(docs): identation and allignment

e5203f1

fix(docs): identation and allignment

9e57f74

fix(docs): identation and allignment

cc5dac1

SuGlider moved this from In Progress to In Review in Arduino ESP32 Core Project Roadmap Dec 4, 2025

P-R-O-C-H-Y approved these changes Dec 4, 2025

View reviewed changes

pedrominatel reviewed Dec 5, 2025

View reviewed changes

docs/en/matter/ep_temperature_controlled_cabinet.rst Outdated Show resolved Hide resolved

fix(docs): reorganization of the text

e118e02

Reinstate important note about mutually exclusive features for temperature control modes.

pedrominatel approved these changes Dec 5, 2025

View reviewed changes

SuGlider added Status: Pending Merge Pull Request is ready to be merged and removed Status: Review needed Issue or PR is awaiting review labels Dec 6, 2025

pre-commit-ci-lite bot and others added 4 commits December 6, 2025 18:32

ci(pre-commit): Apply automatic fixes

27ab18e

fix(matter_example): bad ci.yml content

b8d3fb2

ci(pre-commit): Apply automatic fixes

e72dd51

fix(matter): bad content in source file

9fae46d

Refactor MatterTemperatureControlledCabinet to support both temperature_number and temperature_level features. Introduce new methods for handling temperature levels and update existing methods to accommodate the new structure.

me-no-dev approved these changes Dec 8, 2025

View reviewed changes

me-no-dev merged commit 792297f into master Dec 8, 2025
80 checks passed

github-project-automation bot moved this from In Review to Done in Arduino ESP32 Core Project Roadmap Dec 8, 2025

me-no-dev deleted the feat/matter_temperature_controlled_cabinet_ep branch December 8, 2025 12:02

feat(matter): adds temperature controlled cabinet ep #12104

feat(matter): adds temperature controlled cabinet ep #12104

Conversation

SuGlider commented Dec 4, 2025

Description of Change

Test Scenarios

Related links

Uh oh!

github-actions bot commented Dec 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Dec 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

github-actions bot commented Dec 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Memory usage test (comparing PR against master branch)

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

github-actions bot commented Dec 4, 2025 •

edited

Loading

github-actions bot commented Dec 4, 2025 •

edited

Loading

github-actions bot commented Dec 4, 2025 •

edited

Loading