Open
Conversation
replace undefined with one missing semicolon adjust type property
balloob
reviewed
Sep 12, 2023
| active | ||
| ?indeterminate=${progress === undefined} | ||
| .progress=${progress !== undefined ? progress / 100 : undefined} | ||
| .progress=${progress !== undefined ? progress / 100 : 1} |
Member
There was a problem hiding this comment.
This should be using the ifDefined helper from lit.
Contributor
Author
There was a problem hiding this comment.
I've tried adding ifDefined, but I get this error then:
not sure if this is a false-positive, but lit-plugin shows me many errors, including Type 'true' is not assignable to 'string' for empty scrimClickAction, ref: #303
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While browsing the code in VS I noticed some small places that showed errors when I removed
ignoreDeprecationsin tsconfig.I've added the missing semicolon in src/devices/configured-device-card.ts and also adjusted the type property in src/components/process-dialog.ts and src/components/remote-process.ts
There was a missing cast in src/wizard/wizard-dialog.ts, so I've also added it.