-
Notifications
You must be signed in to change notification settings - Fork 82
chore: update @eslint/* dep, add legacy-peer-deps, use ESLint v10
#593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| "dependencies": { | ||
| "@eslint/core": "^0.17.0", | ||
| "@eslint/plugin-kit": "^0.4.1", | ||
| "@eslint/core": "^1.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same question as eslint/json#190 (comment). We can clarify there, just wanted to leave a note here as well so that we don't merge until this is clarified.
| strategy: | ||
| matrix: | ||
| os: [ubuntu-latest] | ||
| eslint: [9] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also decide on whether we want this plugin to still support ESLint v9 when ESLint v10 final is released.
Prerequisites checklist
What is the purpose of this pull request?
This PR was motivated by eslint/json#187 (comment).
Currently, when updating
@eslint/coreto v1.0.0, CI fails because@eslint/core@1.0.0does not match ESLint v9@eslint/core@1.0.0includes type information for ESLint v10, which causes the type mismatch.So, I've updated ESLint to
>=10.0.0-alpha.0 <10.0.0 || ^10.0.1. (Ref: https://github.com/eslint/eslint/blob/main/packages/eslint-config-eslint/package.json#L66)When I update ESLint to
>=10.0.0-alpha.0 <10.0.0 || ^10.0.1, the following error occurs, so I added thelegacy-peer-depsoption to.npmrc.This change follows the approach in eslint/eslint#20281
What changes did you make? (Give an overview)
In this PR, I've updated
@eslint/core, addlegacy-peer-deps, and use ESLint v10 pre-release.Related Issues
Ref: #584, #586, eslint/json#187 (comment), eslint/eslint#20281
Is there anything you'd like reviewers to focus on?
N/A
TODO for myself:
scopeManager.addGlobals:var/function, addaddGlobals()js#682