Skip to content

Conversation

@lumirlumir
Copy link
Member

@lumirlumir lumirlumir commented Dec 2, 2025

Prerequisites checklist

What is the purpose of this pull request?

This PR was motivated by eslint/json#187 (comment).

Currently, when updating @eslint/core to v1.0.0, CI fails because @eslint/core@1.0.0 does not match ESLint v9

@eslint/core@1.0.0 includes type information for ESLint v10, which causes the type mismatch.

So, I've updated ESLint to >=10.0.0-alpha.0 <10.0.0 || ^10.0.1. (Ref: https://github.com/eslint/eslint/blob/main/packages/eslint-config-eslint/package.json#L66)


When I update ESLint to >=10.0.0-alpha.0 <10.0.0 || ^10.0.1, the following error occurs, so I added the legacy-peer-deps option to .npmrc.

This change follows the approach in eslint/eslint#20281

image

What changes did you make? (Give an overview)

In this PR, I've updated @eslint/core, add legacy-peer-deps, and use ESLint v10 pre-release.

Related Issues

Ref: #584, #586, eslint/json#187 (comment), eslint/eslint#20281

Is there anything you'd like reviewers to focus on?

N/A


TODO for myself:

scopeManager.addGlobals:

@eslintbot eslintbot added this to Triage Dec 2, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Dec 2, 2025
@lumirlumir
Copy link
Member Author

Unlike the PRs in JSON and CSS, the Markdown plugin needs further investigation to support ESLint v10. I'm marking this as a draft for now and will investigate it soon.

@lumirlumir lumirlumir moved this from Needs Triage to Implementing in Triage Dec 2, 2025
"dependencies": {
"@eslint/core": "^0.17.0",
"@eslint/plugin-kit": "^0.4.1",
"@eslint/core": "^1.0.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question as eslint/json#190 (comment). We can clarify there, just wanted to leave a note here as well so that we don't merge until this is clarified.

strategy:
matrix:
os: [ubuntu-latest]
eslint: [9]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also decide on whether we want this plugin to still support ESLint v9 when ESLint v10 final is released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Implementing

Development

Successfully merging this pull request may close these issues.

3 participants