ci: centralize ci-package-manager
#169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
There was a problem hiding this comment.
Pull request overview
This PR centralizes the ci-package-manager workflow by replacing the local 131-line ci-build-all-pm.yml workflow with a 14-line wrapper that delegates to a reusable workflow in the eslint/workflows repository. This aligns with the ESLint organization's broader effort to centralize CI workflows for easier maintenance and consistency across projects.
Key Changes
- Deleted the local
ci-build-all-pm.ymlworkflow containing package manager installation tests - Created new
ci-package-manager.ymlthat calls the centralized workflow - Renamed the workflow from "CI Build install" to "ci-package-manager" for clarity
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.github/workflows/ci-package-manager.yml |
New workflow file that delegates to the centralized eslint/workflows reusable workflow for package manager testing |
.github/workflows/ci-build-all-pm.yml |
Removed local workflow implementation that tested npm, Yarn v1, Yarn Modern, pnpm, and bun installations |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
aladdin-add
approved these changes
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
In this PR, I've centralized the
ci-package-managerworkflow as part of the effort to centralize workflows (ref: eslint/workflows#4).I renamed the workflow file from
ci-build-all-pmtoci-package-managerto make its purpose clearer.For detailed context, please refer to eslint/workflows#25.
What changes did you make? (Give an overview)
In this PR, I centralized the
ci-package-managerworkflow.Related Issues
Refs: eslint/workflows#25, eslint/workflows#4
Is there anything you'd like reviewers to focus on?
N/A