chore: update dependencies under @eslint scope#374
Conversation
✅ Deploy Preview for eslint-code-explorer ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
Updates @eslint/* scoped dependencies to their latest versions (separating out espree / eslint-scope updates per the PR description), likely to support newer language parsing capabilities (notably Markdown v8).
Changes:
- Bump
@eslint/css,@eslint/json, and@eslint/markdownto their latest major versions. - Bump
@eslint/coredevDependency to^1.2.0. - Regenerate
package-lock.jsonto reflect the updated dependency graph (including new transitive deps like math-related Markdown packages).
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package.json | Updates @eslint/* dependency versions. |
| package-lock.json | Lockfile updates for new @eslint/* versions and their transitive dependencies/engines. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "@eslint/css": "^1.1.0", | ||
| "@eslint/js": "^9.39.4", | ||
| "@eslint/json": "^0.14.0", | ||
| "@eslint/markdown": "^7.5.1", | ||
| "@eslint/json": "^1.2.0", | ||
| "@eslint/markdown": "^8.0.1", |
There was a problem hiding this comment.
These @eslint package updates now require Node.js ^20.19.0 || ^22.13.0 || >=24 (per their published engines). The repo currently declares "engines.node": ">= 20" and uses an unpinned ".nvmrc" of "20", which implies support for Node 20.0–20.18 even though installs will fail there. Please align the project's declared/CI Node version with the new minimum (e.g., bump engines.node and pin .nvmrc accordingly).
There was a problem hiding this comment.
It appears Netlify automatically installs the latest Node.js 20 during the build, so this seems safe:
Would it be better to specify Node.js 20 version more explicitly to ensure future compatibility?
There was a problem hiding this comment.
Yes we can surely specify the a node js version explicitly. This PR also raises a warning about the Node.js version compatibility:
One option is: ^20.19.0 || ^22.13.0 || >=24
However, since Node 20 reached end-of-life in April 2026, we could drop support for it entirely and move to a more forward-looking range: ^22.12.0 || >=24
This aligns with the requirements of @rolldown/plugin-babel@0.2.2, which officially supports: >=22.12.0 || ^24.0.0 (Node 20 is excluded)
Although the plugin still works on Node 20.19+, it shows warnings, so support is only partial.
For a cleaner and future-proof setup, it’s better to:
Use ^22.12.0 || >=24 in engines
Set .nvmrc to Node 22
Or if want to go practically we can have: ^20.19.0 || ^22.13.0 || >=24
There was a problem hiding this comment.
Great. I believe an issue has been opened and there is no blocking problem for this PR since Netlify uses Node.js 20.20+. Should this PR be postponed, or can it be merged?
If it's acceptable, it would be nice if we can merge this PR without blocking, as the language plugin version discrepancy makes developing language plugins a bit difficult.
amareshsm
added
the
accepted
Prerequisites checklist
AI acknowledgment
What is the purpose of this pull request?
While working on #299, I found that some packages under the
@eslintscope were not using their latest versions, so I updated them all.Renovate could have handled this, but its update included changes for
espreeandeslint-scope, which are currently in a draft PR, so I separated those updates.FYI,
eslintcan't be updated to v10 right now becauseeslint-plugin-react-hooksdoesn't yet supporteslintv10 as a peer dependency.What changes did you make? (Give an overview)
This PR updates
@eslintdependencies to its latest.Related Issues
N/A
Is there anything you'd like reviewers to focus on?
N/A