fix(i18n): mop up 4 remaining hardcoded strings in stats/run/sessions#916
Closed
Evan-Pycraft wants to merge 2 commits into
Closed
fix(i18n): mop up 4 remaining hardcoded strings in stats/run/sessions#916Evan-Pycraft wants to merge 2 commits into
Evan-Pycraft wants to merge 2 commits into
Conversation
Owner
|
Thanks — the rest is exactly the kind of mop-up I want. One small thing on the MCP reuse: Otherwise good to merge. |
Contributor
Author
|
Merged into #945 (combined CLI + dashboard i18n) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
补漏 4 处 CLI 硬编码字符串。
CLI (3 files):
stats.ts— 两条 CLI 用法提示改用t()run.ts— API key 缺失提示改用t(),MCP hint 复用已有 keysessions.ts— 空会话提示改用t()i18n:
src/i18n/EN.ts+zh-CN.ts: +3 sections (stats, run, sessions), 4 keysTest plan
npm run lint— cleannpx tsc --noEmit— cleangrep -rn 'run \\\\reasonix\|no saved sessions' src/cli/commands/` — clean