Skip to content

fix(i18n): mop up 4 remaining hardcoded strings in stats/run/sessions#916

Closed
Evan-Pycraft wants to merge 2 commits into
esengine:mainfrom
Evan-Pycraft:feat/i18n-mop-up-2
Closed

fix(i18n): mop up 4 remaining hardcoded strings in stats/run/sessions#916
Evan-Pycraft wants to merge 2 commits into
esengine:mainfrom
Evan-Pycraft:feat/i18n-mop-up-2

Conversation

@Evan-Pycraft
Copy link
Copy Markdown
Contributor

Summary

补漏 4 处 CLI 硬编码字符串。

CLI (3 files):

  • stats.ts — 两条 CLI 用法提示改用 t()
  • run.ts — API key 缺失提示改用 t(),MCP hint 复用已有 key
  • sessions.ts — 空会话提示改用 t()

i18n:

  • src/i18n/EN.ts + zh-CN.ts: +3 sections (stats, run, sessions), 4 keys

Test plan

  • npm run lint — clean
  • npx tsc --noEmit — clean
  • grep -rn 'run \\\\reasonix\|no saved sessions' src/cli/commands/` — clean

@esengine
Copy link
Copy Markdown
Owner

Thanks — the rest is exactly the kind of mop-up I want.

One small thing on the MCP reuse: mcpLifecycle.failedSetupConfigHint already starts with (see EN.ts:1535), and the new template in run.ts still prefixes → ${t(...)} — rendered output ends up as → → run \reasonix setup`…. Drop the from the template (keep just\n ${t("mcpLifecycle.failedSetupConfigHint")}\n`) and the line matches the pre-PR output exactly.

Otherwise good to merge.

@Evan-Pycraft
Copy link
Copy Markdown
Contributor Author

Merged into #945 (combined CLI + dashboard i18n)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants