Django 4 Support, drop python 3.6-3.7 support#57
Open
stefanwitchell1990 wants to merge 2 commits intoescaped:masterfrom
Open
Django 4 Support, drop python 3.6-3.7 support#57stefanwitchell1990 wants to merge 2 commits intoescaped:masterfrom
stefanwitchell1990 wants to merge 2 commits intoescaped:masterfrom
Conversation
|
Any updates here? |
|
so many Contributors.. :( |
Contributor
|
fixes #51 |
Contributor
|
@escaped Thank you for the package! Any possibility you could take a look? |
pmourelle
approved these changes
Sep 23, 2023
pmourelle
left a comment
There was a problem hiding this comment.
Looks good, pretty straightforward and awesome. Am I missing something?
|
I installed the package from pip but it still has the error with 'ugettext'. |
|
@ShabaniAmir thats cos this fix aint merged. Looks like this package has been abandoned sadly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added Django 4.
Removed Python 3.6 - 3.7 support as Django 4 requires minimum 3.8
I noticed that when upgrading my project to Django 4, I was getting an error on;
cannot import name 'ugettext_lazy' from 'django.utils.translation'However looks like it was fixed on -> https://github.com/escaped/django-inline-actions/pull/43/files but not released.
Please include a summary of the proposed changes.
Removal off Python 3.6-3.7
Added Django 4
Fixes #(issue)
Tests are passing as the initial issue was fixed in -> https://github.com/escaped/django-inline-actions/pull/43/files
Checklist
CHANGELOG.mdCONTRIBUTORS.md