feat: migrate left-pad and pad-left to ast-grep, add computeCallReplacementEdits util#197
Merged
Conversation
Collaborator
|
is the description just wrong? it contains a lot more than left-pad and pad-left. let me know before i review 👍 |
Contributor
Author
I've added |
gameroman
force-pushed
the
pad-left
branch
2 times, most recently
from
f32bffc to
4bc8015
Compare
dreyfus92
reviewed
May 25, 2026
Collaborator
dreyfus92
left a comment
dreyfus92
left a comment
There was a problem hiding this comment.
overall looks good, but you have 2 options here either you update the pr's title & desc or split this to match the pr's intention
gameroman
changed the title
left-pad and pad-left to ast-grepleft-pad and pad-left to ast-grep, add computeCallReplacementEdits util
gameroman
force-pushed
the
pad-left
branch
2 times, most recently
from
9c78cdd to
2203ade
Compare
dreyfus92
previously approved these changes
May 25, 2026
43081j
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
See #111
Closes #110
📚 Description
This migrates the
left-padandpad-leftcodemods to use ast-grepAdds shared
computeCallReplacementEditsutilcomputeCallReplacementEdits, where relevant