Match against ES5/ES6 JavaScript files#153
Open
ilanbiala wants to merge 4 commits intoes-analysis:masterfrom
Open
Match against ES5/ES6 JavaScript files#153ilanbiala wants to merge 4 commits intoes-analysis:masterfrom
ilanbiala wants to merge 4 commits intoes-analysis:masterfrom
Conversation
Closed
test/plato_test.js
Outdated
There was a problem hiding this comment.
Seems that text doesn't exist. Is a typo, maybe it should be test instead of.
Contributor
Author
There was a problem hiding this comment.
@MathRobin sorry your response got cut off, instead of what? If you look at the files changed tab, GitHub says it was added I believe.
There was a problem hiding this comment.
Sorry for my bad english.
I would like to say that you did a mistake. On line 138, you wrote the word "text" instead of the word "test". That's why the tests don't passed.
Closed
kyungilpark
added a commit
to kyungilpark/plato
that referenced
this pull request
Jun 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #144.