Add inheritdoc to generated Json serializers#22
Merged
erri120 merged 4 commits intoerri120:mainfrom Nov 12, 2024
Merged
Conversation
Owner
Contributor
Author
|
👍 updated |
Contributor
Author
|
See the description for another added change |
erri120
approved these changes
Nov 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're getting build warnings due to the members of this class not having doc strings, this just adds "inheritdoc" to these 4 members (and updates the tests).
Also fixes a bug where we were always emitting doc string references to EF even when EF wasn't installed or used. For now, just deleted the doc references to these classes and instead use the un-annotated names. This also removes 2 warnings for every generated value object