feat(tp): add '-silent' flag for /tp command with premission support#1151
Open
VladOliinyk wants to merge 2 commits intoerikzimmermann:developfrom
Open
feat(tp): add '-silent' flag for /tp command with premission support#1151VladOliinyk wants to merge 2 commits intoerikzimmermann:developfrom
VladOliinyk wants to merge 2 commits intoerikzimmermann:developfrom
Conversation
- Add `notifyPlayer` field to `TeleportOptions` for explicit state transfer. - Implement safe argument parsing in `CTeleport` (removes `-silent` from any position). - Add permission check for silent teleport usage. - Overload `ITeleportCommandHandler` methods to propagate notification state. - Update `PlayerTeleport` to log to console instead of chat when silent mode is active.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
notifyPlayerfield toTeleportOptionsfor explicit state transfer.CTeleport(removes-silentfrom any position).ITeleportCommandHandlermethods to propagate notification state.PlayerTeleportto log to console instead of chat when silent mode is active.Tested on Paper 1.21.11 (
Paper version 1.21.11-88-main@8556cb4).Goal reached, works for me, will update this thread and/or Discord if I find any bugs/errors/etc.