Skip to content

Fix two post-split UX issues (schema lookup on Run Repro, toolbar overflow) #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erikdarlingdata merged 1 commit into from
May 14, 2026
+20 −6
Merged

Fix two post-split UX issues (schema lookup on Run Repro, toolbar overflow) #335

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions src/PlanViewer.App/Controls/QuerySessionControl.axaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,19 @@
<Border Grid.Row="0" Background="{DynamicResource BackgroundDarkBrush}" Padding="8,6"
BorderBrush="{DynamicResource BorderBrush}" BorderThickness="0,0,0,1">
<DockPanel>
<StackPanel Orientation="Horizontal" DockPanel.Dock="Left" Spacing="4">
<TextBlock x:Name="StatusText" DockPanel.Dock="Right"
HorizontalAlignment="Right" VerticalAlignment="Center"
FontSize="11" Foreground="{DynamicResource ForegroundBrush}"
TextTrimming="CharacterEllipsis" Margin="8,0,0,0"/>
<WrapPanel Orientation="Horizontal">
<WrapPanel.Styles>
<Style Selector="Button">
<Setter Property="Margin" Value="0,2,4,2"/>
</Style>
<Style Selector="ComboBox">
<Setter Property="Margin" Value="0,2,4,2"/>
</Style>
</WrapPanel.Styles>
<Button x:Name="ConnectButton" Content="Connect" Click="Connect_Click"
Height="28" Padding="8,0" FontSize="12"
Theme="{StaticResource AppButton}"
Expand Down Expand Up @@ -84,11 +96,7 @@
Height="28" Padding="10,0" FontSize="12"
Theme="{StaticResource AppButton}"
ToolTip.Tip="Configure SQL formatting options"/>
</StackPanel>
<TextBlock x:Name="StatusText" DockPanel.Dock="Right"
HorizontalAlignment="Right" VerticalAlignment="Center"
FontSize="11" Foreground="{DynamicResource ForegroundBrush}"
TextTrimming="CharacterEllipsis"/>
</WrapPanel>
</DockPanel>
</Border>

Expand Down
6 changes: 6 additions & 0 deletions src/PlanViewer.App/MainWindow.PlanViewer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -489,6 +489,12 @@ private async Task GetActualPlanFromFile(PlanViewerControl viewer)
// Replace loading content with the actual plan
var actualViewer = new PlanViewerControl();
actualViewer.Metadata = metadata;
// Inherit the connection used to run the repro so schema lookups
// (Show Indexes, Show Table Definition) remain available on the
// new plan tab.
actualViewer.ConnectionString = connectionString;
actualViewer.SetConnectionServices(_credentialService, _connectionStore);
actualViewer.SetConnectionStatus(dialog.ResultConnection.ServerName, database);
actualViewer.LoadPlan(actualPlanXml, "Actual Plan", queryText);

tab.Content = CreatePlanTabContent(actualViewer);
Expand Down
Loading