Split PlanAnalyzer.cs into partial classes#329
Merged
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Add powered-by line on landing page
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Add Darling Data favicon
Uses the Darling Data barbell logo as hero image when shared on social media. Also adds meta description for SEO. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Add Open Graph meta tags for social sharing
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Clarify social share description
Merge dev: HTML export for plan analysis (#182)
This reason means something in the query blocks parallelism (scalar UDFs, table variable inserts, etc.) — that's worth a Warning, not Info. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Fix Rule 3: CouldNotGenerateValidParallelPlan stays Warning
Adds human-readable messages for all 25 known reasons. Severity: - Warning: actionable reasons (UDFs, cursors, table variables, remote queries, trace flags, hints, DML OUTPUT, writeback variables) - Info: passive/environmental (cost below threshold, edition limits, memory-optimized tables, upgrade mode, index build edge cases) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Expand Rule 3 to cover all NonParallelPlanReason values
Merge dev: plan sharing and export (#182)
Release v1.4.1
Release v1.4.2
Release v1.4.3
Merge dev to main (v1.4.3 + logo fix)
Merge dev: HTTPS plan sharing API
Release: issue #178 round 3 feedback (items 17-25)
Release v1.5.0 — maximum benefit scoring
Release: analytics for Plan Analyzer web app
Merge dev to main
Merge dev to main — Joe #215 feedback through b1/b7
Release v1.6.0
Release v1.7.0 — wait stats as warnings
Release v1.7.1 — render benefit % and actionable fix
Release v1.7.2 — operator self-time fix + decimal benefit %
Release v1.7.3 — visible web viewer version
Release v1.7.4 — external-wait formula + CPU:Elapsed adjustment
Release v1.7.6 — C1 memory color + C4 compile time + C8 expensive-op + C9 columnstore
Release v1.7.7 — D3 content strip + legacy marker + drop Rule 21
Release v1.7.8 — batch-mode pipelined self-time (#215 D1)
Release v1.8.0 — Joe feedback E1-E12 batch
Release: dev -> main
Release v1.10.0
Move-only refactor; no behavior changes. PlanAnalyzer.cs (2,238 lines)
split into 5 partials:
Statement (439) - AnalyzeStatement (statement-level rules)
Node (777) - AnalyzeNodeTree + AnalyzeNode (operator rules)
Detection (248) - predicate/pattern helpers (HasNotIn, IsAntiSemi,
IsRowstoreScan, IsProbeOnly, DetectNonSargable,
IsOrExpansionChain, HasAdaptiveJoin, ...)
Timing (345) - operator CPU/elapsed helpers + ScanImpact + memory
Helpers (275) - severity overrides, wait labels, format, truncate
Main file now 115 lines — class declaration, regex constants, static
dictionaries (RuleWarningTypes/WarningTypeToRule), static ctor, the
public Analyze() entry point, and the ScanImpact record.
PlanViewer.Web.csproj updated to link the new partial files.
Build clean: 0 errors, 0 warnings on PlanViewer.sln.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move-only refactor of
PlanViewer.Core/Services/PlanAnalyzer.cs(2,238 lines) into 5 topical partial-class files.File sizes
PlanAnalyzer.cs(main)LegacyWarningTypes/RuleWarningTypes/WarningTypeToRuledictionaries, static ctor, publicAnalyze(), nestedScanImpactrecord.Statement.csAnalyzeStatement— statement-level rules (~440-line method).Node.csAnalyzeNodeTree+AnalyzeNode— operator-level rules.Detection.cs.Timing.csGetOperatorOwnElapsedMs,GetPerThreadOwnElapsed,GetEffectiveChildCpuMs, etc.) +BuildScanImpactDetails+ memory consumers.Helpers.csFormatNodeRef,IdentifyRowGoalCause,TruncateBehavior
partial(waspublic static class).internalmembers (GetOperatorOwnElapsedMs,GetOperatorMaxThreadOwnCpuMs) remaininternal;BenefitScorerstill calls them.PlanViewer.Web.csprojupdated to link the new partial files (Web links Core source files directly, not via project reference).Test plan
dotnet build PlanViewer.sln— 0 errors, 0 warnings (all 5 projects: Core, App, Cli, Tests, Web)dotnet test tests/PlanViewer.Core.Tests— analyzer test suite still passes🤖 Generated with Claude Code