Fix FinOps CI: sql_variant CONCAT and test table count#465
Merged
erikdarlingdata merged 1 commit intodevfrom Mar 7, 2026
Merged
Fix FinOps CI: sql_variant CONCAT and test table count#465erikdarlingdata merged 1 commit intodevfrom
erikdarlingdata merged 1 commit intodevfrom
Conversation
- CONVERT SERVERPROPERTY results to nvarchar(128) in CONCAT call to avoid implicit sql_variant conversion error (Msg 257) - Update SchemaStatements_MatchTableCount assertion from 24 to 26 for the two new FinOps tables (database_size_stats, server_properties) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Msg 257in server_properties_collector: SERVERPROPERTY returnssql_variantwhich can't be used in CONCAT implicitly — added explicit CONVERT tonvarchar(128)SchemaStatements_MatchTableCounttest assertion from 24 to 26 for the two new FinOps tables🤖 Generated with Claude Code