Skip to content

Lite - fixed sort on columns that are formatted for seconds or milliseconds - branch fixed#452

Merged
erikdarlingdata merged 2 commits intoerikdarlingdata:devfrom
dphugo:fix/lite-sort-formatted-columns-by-value
Mar 6, 2026
Merged

Lite - fixed sort on columns that are formatted for seconds or milliseconds - branch fixed#452
erikdarlingdata merged 2 commits intoerikdarlingdata:devfrom
dphugo:fix/lite-sort-formatted-columns-by-value

Conversation

@dphugo
Copy link

@dphugo dphugo commented Mar 6, 2026

What does this PR do?

This PR fixes bug/issue #450.

  • Used the SortMemberPath property to point to the numeric value for the sorting of the columns that are formatted for seconds or milliseconds under the Server Tab -> Collection Health tabs.
  • Increased some column widths to ensure complete header is shown.

Which component(s) does this affect?

  • Full Dashboard
  • Lite Dashboard
  • Lite Tests
  • SQL collection scripts
  • CLI Installer
  • GUI Installer
  • Documentation

How was this tested?

Describe the testing you've done. Include:

  • SQL Server version(s) tested against:
    • SQL Server 2022
  • Steps to verify the change works:
    • Complied and ran the PerformanceMonitorLite project
    • Waited for Collection to finish
    • Browsed to the affected data grids under Server Tab -> Collection Health tabs.
    • Clicked on the affected columns to verify visually that sorting was applied correctly. Also specifically where the output could be a mix of "s" and "ms".

Checklist

  • I have read the contributing guide
  • My code builds with zero warnings (dotnet build -c Debug)
  • I have tested my changes against at least one SQL Server version
  • I have not introduced any hardcoded credentials or server names

erikdarlingdata and others added 2 commits March 3, 2026 18:02
…, miliseconds or both to order correctly.

- Used the SortMemberPath property to point to the numeric value.
- Increased some widths of columns to ensure complete header is shown.
@dphugo dphugo marked this pull request as ready for review March 6, 2026 15:41
Copy link
Owner

@erikdarlingdata erikdarlingdata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good — clean, minimal fix. All 7 SortMemberPath additions point to real numeric properties on the backing model classes (DurationMs, SqlDurationMs, DuckDbDurationMs, AvgDurationMs). Column width bumps are reasonable.

Approved and merging. I'll open a follow-up issue for other formatted duration columns elsewhere in the app that have the same mixed-unit sorting problem.

@erikdarlingdata erikdarlingdata merged commit 478f915 into erikdarlingdata:dev Mar 6, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants