Add builder.maxblobs flag #18477
Merged
Add builder.maxblobs flag #18477
+50
−70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yperbasis
requested review from
AskAlexSharov,
Giulio2002 and
mh0lt
as code owners
taratorio
reviewed
Jan 6, 2026
| if cfg.miningState.MiningConfig.MaxBlobsPerBlock != nil { | ||
| maxBlobs = min(maxBlobs, *cfg.miningState.MiningConfig.MaxBlobsPerBlock) | ||
| } | ||
| remainingBlobGas = maxBlobs*params.GasPerBlob - *header.BlobGasUsed |
Member
There was a problem hiding this comment.
addTransactionsToMiningBlock has similar logic for the blob gas pool, e.g.:
if header.BlobGasUsed != nil {
gasPool.AddBlobGas(chainConfig.GetMaxBlobGasPerBlock(header.Time) - *header.BlobGasUsed)
}
we should update that there too or even better to extract it in a shared func and re-use in both places
Member
Author
There was a problem hiding this comment.
I thought about it, but, since addTransactionsToMiningBlock is always called after getNextTransactions, it's unnecessary to re-apply the cap logic there.
Member
There was a problem hiding this comment.
Yea, I thought the same but saw it as a 2nd line of defence in case the txnprovider doesn't exactly honour the blob gas target. And also for consistency between the 2 code points. But not a big deal, it is for a minor override flag anyway.
taratorio
approved these changes
Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.