execution/exec: remove duplicated historyMode switch in RunTxTaskNoLock#18475
Closed
phrwlk wants to merge 1 commit intoerigontech:mainfrom
Closed
execution/exec: remove duplicated historyMode switch in RunTxTaskNoLock#18475phrwlk wants to merge 1 commit intoerigontech:mainfrom
phrwlk wants to merge 1 commit intoerigontech:mainfrom
Conversation
Collaborator
|
🤖 Closed by automated review. This PR appears to be an AI-generated stylistic/convention change (dead code removal, unused variable cleanup, redundant code removal) from a non-core contributor. These types of changes are not being accepted at this time. If you believe this was closed in error, please reach out to a maintainer. |
Collaborator
|
[SharovBot] 🤖 Closed by automated review. This PR appears to be an AI-generated stylistic/convention change (dead code removal, unused variable cleanup, redundant code removal) from a non-core contributor. These types of changes are not being accepted at this time. If you believe this was closed in error, please reach out to a maintainer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change removes a duplicated IsHistoric()/historyMode conditional at the start of RunTxTaskNoLock, leaving a single switch after the optional chainTx initialisation. The upper block was logically dead: after it runs, the second block with the same condition never changes historyMode again, so it only adds noise and confusion.
By keeping the lower block we ensure that the choice between HistoryReaderV3 and buffered ReaderV3 is made after chainTx is opened in background workers, which is the more natural place to reconfigure the state reader. Behaviour is otherwise unchanged, but the control flow is simpler and easier to reason about.