execution/stagedsync/headerdownload: avoid redundant RLP encoding #18461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yperbasis
approved these changes
Dec 29, 2025
Member
|
Nice catch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Persisted links immediately drop header and headerRaw fields and only keep hash and block number. AddHeadersFromSnapshot was still encoding headers to RLP and passing both header and headerRaw into addHeaderAsLink, even though this data was discarded for persisted links. This change stops encoding headers to RLP and only initializes ChainSegmentHeader with hash and number for persisted links, keeping the behavior the same while removing unnecessary allocations and work during snapshot-based header prefill.