node/cli: simplify prune distance flags in Cobra path#18418
Closed
radik878 wants to merge 1 commit intoerigontech:mainfrom
Closed
node/cli: simplify prune distance flags in Cobra path#18418radik878 wants to merge 1 commit intoerigontech:mainfrom
radik878 wants to merge 1 commit intoerigontech:mainfrom
Conversation
Collaborator
|
🤖 Closed by automated review. This PR appears to be an AI-generated stylistic/convention change (dead code removal, unused variable cleanup, redundant code removal) from a non-core contributor. These types of changes are not being accepted at this time. If you believe this was closed in error, please reach out to a maintainer. |
Collaborator
|
[SharovBot] 🤖 Closed by automated review. This PR appears to be an AI-generated stylistic/convention change (dead code removal, unused variable cleanup, redundant code removal) from a non-core contributor. These types of changes are not being accepted at this time. If you believe this was closed in error, please reach out to a maintainer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ApplyFlagsForEthConfigCobra previously initialized prune distances with math.MaxUint64 and then conditionally overwrote them based on *uint64 pointers returned by pflag. Those pointers are never nil, so the extra initialization and nil checks were dead code and did not affect behavior.