add internal/platform/utils_js.go to allow building under wasm#74
Open
rcoreilly wants to merge 3 commits intoergochat:masterfrom
Open
add internal/platform/utils_js.go to allow building under wasm#74rcoreilly wants to merge 3 commits intoergochat:masterfrom
rcoreilly wants to merge 3 commits intoergochat:masterfrom
Conversation
Member
|
Sorry I missed this notification! Were you able to test the actual functionality here? |
Author
|
Not yet -- it will be a while before I will be able to do so, so you might consider merging this and then I can report back later: at least this allows building! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows readline to be built under wasm (js). It is just a copy of the windows version which is mostly stubbed it seems. It works to allow building but I was not able to test actual functionality yet.