Make SatAdj unit tests hardware portable#3184
Open
pressel wants to merge 5 commits into
Open
Conversation
AMLattanzi
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes the Saturation Adjustment (SatAdj) unit tests hardware portable through AMReX and improves the inline documentation around the SatAdj test suite.
This is a testing and documentation-only update. It does not change the SatAdj physical formulation or production SatAdj physics behavior.
Changes
MultiFabunit tests so they run through an AMReX-portable path rather than being skipped in GPU builds.SatAdj::AdjustSatAdjCellfrom insideamrex::ParallelFor.Motivation
The previous SatAdj unit tests covered the scalar physics well, but the
MultiFabpublic-flow tests skipped GPU builds. Production SatAdj executesAdjustSatAdjCellinside an AMReXParallelFor, so the tests should exercise that hardware-portable path as well.This PR closes that gap without adding a separate GPU-only implementation of the tests. The same AMReX-portable test logic is used across backends.
What this does not change