[Dycore] Acoustic Substepping W/ Moisture#3169
Draft
AMLattanzi wants to merge 27 commits into
Draft
Conversation
…ut update moist vars in place; improve qc advection stability.
* remora coupling inputs. * more descriptive file name.
* add tagging and inputs file. * oneway coupling. * Fix refinement criteria and use surf layer with zero bulk coeff to leverage implicit diff. * Fix supercell query.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR explores formulations for the acoustic sub-stepping algorithm with moisture. The approach taken here is to not transport
theta_mbut to constructtheta_mby includingq_vas a fast variableApproach
Additional Changes
Couple the acoustic solver with macrophysics. Tendencies computed for
theta_d & q_vwhileq_cis updated in place.Todo
MoistureType::Noneqvupdate to slow pre (diffusion)qvas a fast variable