Conversation
- Refactor _with_stats() because they referenced 'file_name' outside the function which caused all files to have the same timestamp - Create directories before uploading files - Set timestamps on remote files after uploading - Switch to integer timestamps because the remote filesystem does not show microseconds - Remove extra log lines for each file - Add info log lines about number of files to transfer - Remove TaskGroup from put_dir to avoid sending too many simultaneous requests
It conflicts with W504 so we need to pick one, and W503 is what Black formats to.
araglu
approved these changes
Jun 9, 2025
Collaborator
araglu
left a comment
araglu
left a comment
There was a problem hiding this comment.
This looks good and tests well. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add get_dir and put_dir methods to async client