feat: integrate decided blocks into storage adapter

[CHr15F0x]

Fixes: #3248

[zvolin]

a first pass, will get back to this

[CHr15F0x]

BTW: serialized casm definition as well as serialized sierra definition should be newtyped so that we don't pass around naked Vec<u8> in both cases. But this will be a different PR.

[zvolin]

in general looks good, left some idea, curious what you think.

but maan, I must say those decided:: helpers are veeryy hard to understand, my brain unfolds when I read them 😅 almost a rust riddles

I was thinking if we could make them easier to digest, and in general there are two patterns.

First the match on blockid, each function basically has the same code in latest and number arms, maybe we could just prepare the correct iterator beforehand?

fn blocks_for_id(decided_blocks, id) -> impl Iterator<...> {
    // or just match and Boxes
    blocks.iter().rev().filter(move |(bn, _)| match block_id {
        BlockId::Number(n) => **bn <= n,
        BlockId::Latest => true,
        // decided blocks have no hash
        BlockId::Hash(_) => false,
    })
    // maybe also map out the number at this point?
}

doesn't look too good, but should remove half of the code :p

The other pattern is searchig for classes / contract updates. Another helpers for that could maybe also make it more readable?

fn find_class(block, class_hash) -> Option<&DeclaredClass> {
    block
        .declared_classes
        .iter()
        .find(|c| c.sierra_hash == SierraHash(class_hash.0))
}

• something similar for state updates, should get rid of one round of find_map + then_some

[zvolin]

🚢