breaking: Require websocket URL for Ethereum endpoint#3184
Open
t00ts wants to merge 2 commits intot00ts/robust-l1-gas-pricesfrom
Open
breaking: Require websocket URL for Ethereum endpoint#3184t00ts wants to merge 2 commits intot00ts/robust-l1-gas-pricesfrom
t00ts wants to merge 2 commits intot00ts/robust-l1-gas-pricesfrom
Conversation
Contributor
|
@t00ts I think now would be a good time to merge this -- we're still in the beta phase with 0.22.0, so breaking changes are allowed on |
t00ts
force-pushed
the
t00ts/eth-require-ws-url
branch
from
acce894 to
859610f
Compare
kkovaacs
approved these changes
Feb 19, 2026
t00ts
force-pushed
the
t00ts/eth-require-ws-url
branch
from
859610f to
7bf15df
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're currently just switching the
https://scheme towss://on startup, but that doesn't mean that URL actually supports subscription-based endpoints.Our
EthereumClientrequireswsinternally (provider()usesWsConnect). Furthermore, oursync_and_listentask, which is critical (without it we can't verify L2 state against L1) won't even start if the provider does not support subscriptions.Upon introducing L1 gas validation, this comes up once again as a potential issue.
This PR aims to address this issue in a very straightforward manner:
Pathfinder will no longer start if the URL provided isn't websocket-compatible.
This was part of #3179 but has been decoupled so we can merge at our convenience as it's a breaking change.
Also fixes #3181