Add configset name validation matching collection/core naming rules#36
Draft
Add configset name validation matching collection/core naming rules#36
Conversation
- Add CONFIGSET to SolrIdentifierValidator.IdentifierType enum - Add validateConfigSetName() method in SolrIdentifierValidator - Validate configset name in CloneConfigSet.cloneExistingConfigSet() - Validate configset name in UploadConfigSet.uploadConfigSet() and uploadConfigSetFile() - Add tests for invalid configset names in TestConfigSetsAPI Agent-Logs-Url: https://github.com/epugh/solr/sessions/0bc6a4dc-739c-4e58-b626-e30446c4864b Co-authored-by: epugh <22395+epugh@users.noreply.github.com>
…list Agent-Logs-Url: https://github.com/epugh/solr/sessions/0bc6a4dc-739c-4e58-b626-e30446c4864b Co-authored-by: epugh <22395+epugh@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add validation for configset naming rules
Add configset name validation matching collection/core naming rules
Mar 29, 2026
apache#4214) SOLR-18150: Add SolrBackend abstraction for test/benchmark deployments Created SolrBackend interface to abstract over different Solr deployment types (embedded, remote, Jetty, MiniSolrCloudCluster) with a unified API for collection/configSet management, diagnostics, and node URL access. JettySolrRunner now manages a HttpJettySolrClient instance, get via getSolrClient. This PR only introduces the abstraction; follow-on PRs will add callers in benchmarks and tests. Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
…ion-for-configset-names
github-actions
bot
added
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Configsets API (both v1 and v2) accepted arbitrary names including invalid characters (
!,",\) and hyphen-prefixed names, while the Admin UI already enforced collection-style naming rules. This inconsistency allowed creation of unusable configsets and potential path traversal via names liketest/../other.Changes
SolrIdentifierValidator— AddedCONFIGSETtoIdentifierTypeenum andvalidateConfigSetName()convenience method, applying the same pattern already used for collections/cores/shards (^(?!\-)[\\._A-Za-z0-9\\-]+$)CloneConfigSet— Validate name before any other checks incloneExistingConfigSet()(v2 CREATE)UploadConfigSet— Validate name at entry of bothuploadConfigSet()anduploadConfigSetFile()(v2 UPLOAD)TestConfigSetsAPI— Added invalid-name assertions totestCreateErrors()andtestUploadErrors()coveringconfigset!,configset",-configset, and names with spacesInvalid names now return HTTP 400:
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
develocity.apache.org/usr/lib/jvm/temurin-21-jdk-amd64/bin/java /usr/lib/jvm/temurin-21-jdk-amd64/bin/java -XX:ReservedCodeCacheSize=256m -XX:TieredStopAtLevel=1 -XX:+UseParallelGC -XX:ActiveProcessorCount=1 --add-exports jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-exports jdk.compiler/com.sun.tools.javac.file=ALL-UNNAMED --add-exports jdk.compiler/com.sun.tools.javac.parser=ALL-UNNAMED --add-exports jdk.compiler/com.sun.tools.javac.tree=ALL-UNNAMED --add-exports jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED(dns block)metadata.google.internal/usr/lib/jvm/temurin-21-jdk-amd64/bin/java /usr/lib/jvm/temurin-21-jdk-amd64/bin/java -Dcommon-solr.dir=/home/REDACTED/work/solr/solr/solr -Dgradle.lib.dir=/home/REDACTED/.gradle/wrapper/dists/gradle-8.10-bin/deqhafrv1ntovfmgh0nh3npr9/gradle-8.10/lib -Dgradle.user.home=/home/REDACTED/.gradle -Dgradle.worker.jar=/home/REDACTED/.gradle/caches/8.10/workerMain/gradle-worker.jar -Djava.awt.headless=true -Djava.security.egd=file:/dev/./urandom -Djava.security.manager=default -Djava.security.policy=/home/REDACTED/work/solr/solr/gradle/testing/randomization/policies/solr-tests.policy -Djava.util.logging.config.file=/home/REDACTED/work/solr/solr/gradle/testing/defaults-tests/logging.properties -Djdk.map.althashing.threshold=0 -Djetty.insecurerandom=1 -Djetty.testMode=1 -Djunit4.childvm.count=1 -Djunit4.childvm.id=0 -Dorg.gradle.internal.worker.tmpdir=/home/REDACTED/work/solr/solr/solr/core/build/tmp/test/work -DtempDir=/home/REDACTED/work/solr/solr/build/tmp/tests-tmp -Dtests.LUCENE_VERSION=10.4.0 -Dtests.asserts=true -Dtests.codec=random(dns block)If you need me to access, download, or install something from one of these locations, you can either:
⚡ Quickly spin up Copilot coding agent tasks from anywhere on your macOS or Windows machine with Raycast.