Skip to content

Migrate SchemaDesignerAPI to JAX-RS V2 annotations with RESTful improvements#23

Draft
Copilot wants to merge 33 commits intomainfrom
copilot/migrate-schemadesignerapi-to-v2-annotations
Draft

Migrate SchemaDesignerAPI to JAX-RS V2 annotations with RESTful improvements#23
Copilot wants to merge 33 commits intomainfrom
copilot/migrate-schemadesignerapi-to-v2-annotations

Conversation

Copy link
Copy Markdown

Copilot AI commented Feb 22, 2026

  • Analyse all mocks in DownloadConfigSetAPITest and GetConfigSetFileAPITest vs other API tests
  • DownloadConfigSetAPITest: replace mock(ConfigSetService) + doAnswer/stubDownloadConfig helper with real FileSystemConfigSetService(createTempDir()) {} (anonymous subclass to access protected constructor); remove unused mock(SolrQueryRequest) and mock(SolrQueryResponse) (pass null instead); write real files with Files.createDirectories+Files.writeString; fix sanitization test assertion to check for sanitized filename string rather than absence of spaces (the Content-Disposition header itself has a space)
  • GetConfigSetFileAPITest: same pattern — real FileSystemConfigSetService, no request/response mocks; null configset dir means not-found, missing file means not-found
  • Fix GetConfigSetFile.downloadFileFromConfig(): handle null return from FileSystemConfigSetService (it silently returns null for missing files instead of throwing IOException) and throw a 404 SolrException — this was a real bug caught by switching from mocks to a real implementation
  • Run gradlew tidy — passes
  • Run both test classes — all 12 tests pass

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: epugh <22395+epugh@users.noreply.github.com>
…mments

Co-authored-by: epugh <22395+epugh@users.noreply.github.com>
…y docs guard)

Co-authored-by: epugh <22395+epugh@users.noreply.github.com>
Copilot AI changed the title Migrate SchemaDesignerAPI from homegrown @EndPoint to JAX-RS V2 annotations Fix schema designer /query wiping indexed docs when sample docs unavailable Feb 22, 2026
…ader, sanitize filename

Co-authored-by: epugh <22395+epugh@users.noreply.github.com>
Copilot AI changed the title Fix schema designer /query wiping indexed docs when sample docs unavailable Migrate SchemaDesignerAPI from homegrown @EndPoint annotations to JAX-RS V2 API Feb 23, 2026
…/docs map for JS rendering

Co-authored-by: epugh <22395+epugh@users.noreply.github.com>
Copilot AI changed the title Migrate SchemaDesignerAPI from homegrown @EndPoint annotations to JAX-RS V2 API Fix schema designer query results not rendering in UI Feb 23, 2026
epugh and others added 5 commits April 2, 2026 11:27
Replace all FlexibleSolrJerseyResponse usages with the specific typed
response POJOs (SchemaDesignerResponse, SchemaDesignerInfoResponse,
SchemaDesignerCollectionsResponse, SchemaDesignerSchemaDiffResponse)
returned by the SchemaDesigner API methods.

Also fix SchemaDesigner.setSchemaObjectField() to handle the add-field
and add-field-type action names used by the Schema API request JSON, so
that response.field is populated for add-field requests and
response.fieldType for add-field-type requests.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Co-authored-by: epugh <22395+epugh@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Co-authored-by: epugh <22395+epugh@users.noreply.github.com>
…i-to-v2-annotations' into copilot/migrate-schemadesignerapi-to-v2-annotations

# Conflicts:
#	solr/core/src/java/org/apache/solr/handler/configsets/DownloadConfigSet.java

Co-authored-by: epugh <22395+epugh@users.noreply.github.com>
Copilot finished work on behalf of epugh April 2, 2026 16:26
Copilot finished work on behalf of epugh April 2, 2026 16:49
Copilot stopped work on behalf of epugh due to an error April 2, 2026 18:02
…s $resource in JS

Agent-Logs-Url: https://github.com/epugh/solr/sessions/adec0806-852d-4a34-a0fb-aef713d8bf76

Co-authored-by: epugh <22395+epugh@users.noreply.github.com>
Copilot finished work on behalf of epugh April 2, 2026 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants