forked from stephane/libmodbus
-
Notifications
You must be signed in to change notification settings - Fork 1
Merging ASCII Support Branch into Master #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ccdMuro
wants to merge
24
commits into
epsilonrt:master
Choose a base branch
from
kernelconcepts:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BTW, I'm think it would be better to remove this function...
Thanks to AlexLonardi.
In order to experiment with new features in libmodbuspp.
Addition of the modbus_rtu_set_recv_filter() and modbus_rtu_get_recv_filter() functions. This makes it possible to process on reception all messages in RTU mode.
…fiicts and adjusting modbus-servial to disable_receive_filter flag
6f8caf9 to
b25629b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Am working on a project which requires to support the modbus ASCII mode.
Using the libmodbusppm which depends on libmodbus, I want to extend it to support ASCII mode but still benefit from all the stuff in v3.1.6. So I decided to merge it all together and it works for me (already tested with the corresponding libmodbuspp).
I know that I broke some API but I Just want to make you know about my changes, and maybe it will be interesting for someone else :)