Skip to content

Conversation

@armtir
Copy link

@armtir armtir commented Nov 9, 2020

No description provided.

Copy link
Member

@beroset beroset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason to use XERCES_CPP_NAMESPACE instead of simply xercesc? This documentation seems to suggest the latter instead.

@armtir
Copy link
Author

armtir commented Nov 9, 2020

Hello, you're right, it's better to use xercesc . In XercesDefs.hpp:110 it's defined as: namespace xercesc = XERCES_CPP_NAMESPACE;

@armtir
Copy link
Author

armtir commented Nov 9, 2020

There is one more issue with the unittest CurlReceiveBuffer.TestBuffer1.
I had to add carriage returns (\r ) to this file: test_buffer1.txt.

@beroset
Copy link
Member

beroset commented Nov 12, 2020

There is one more issue with the unittest CurlReceiveBuffer.TestBuffer1.
I had to add carriage returns (\r ) to this file: test_buffer1.txt.

Yes, I put in a pull request to address that issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants