Add a new xml template for when SDF_VisIt and SDF_C are subprojects o…#8
Open
andymwood wants to merge 1 commit intoepochpic:mainfrom
Open
Add a new xml template for when SDF_VisIt and SDF_C are subprojects o…#8andymwood wants to merge 1 commit intoepochpic:mainfrom
andymwood wants to merge 1 commit intoepochpic:mainfrom
Conversation
…f a CMake superproject This fixes the commit ID and date reported for the SDF library. SDF2.xml assumes that C/src/commit_info.h is present in the source directory, but commit_info.h is created in the CMake build directory. So if a copy is not also in the source directory, VisIt/commit_info.h would be used instead and wrong info about the SDF library would be reported by the plugin.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…f a CMake superproject
This fixes the commit ID and date reported for the SDF library. SDF2.xml assumes that C/src/commit_info.h is present in the source directory, but commit_info.h is created in the CMake build directory. So if a copy is not also in the source directory, VisIt/commit_info.h would be used instead and wrong info about the SDF library would be reported by the plugin.