Remove distributional optional dependency workaround#1059
Merged
nikosbosse merged 3 commits intomainfrom Feb 1, 2026
Merged
Conversation
The {distributional} package has fixed the native pipe issue that
previously caused compatibility problems with R < 4.1. Since
scoringutils now requires R >= 4.1 and the upstream fix is on CRAN,
this removes:
- The conditional ggdist installation in CI (ignore-before-r=4.1.0)
- The conditional evaluation of ggdist chunks in the vignette
- Moves library(ggdist) back to the setup chunk
Closes #947
seabbs-bot
force-pushed
the
issue-947-fix-distributional-dep
branch
from
4fa70a8 to
d34d761
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1059 +/- ##
=======================================
Coverage 97.83% 97.83%
=======================================
Files 35 35
Lines 1845 1845
=======================================
Hits 1805 1805
Misses 40 40 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
seabbs
approved these changes
Jan 30, 2026
Contributor
seabbs
left a comment
seabbs
left a comment
There was a problem hiding this comment.
This looks good to me. Calling for a second review as this is just me and @seabbs-bot as it stands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
{distributional}native pipe issue that has now been fixed upstream{distributional}started using the native pipe|>which required R 4.1+scoringutilsnow requires R >= 4.1 and the upstream fix is on CRAN, this removes:ggdist=?ignore-before-r=4.1.0)library(ggdist)back to the setup chunk in the vignetteCloses #947
Test plan
This was opened by a bot. Please ping @seabbs for any questions.