Trim ranges video load#35
Merged
Merged
Conversation
Co-authored-by: me <me@kentcdodds.com>
|
Cursor Agent can help with this pull request. Just |
|
🎉 This PR is included in version 1.13.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clear trim ranges and selection state when a new video is loaded to prevent invalid ranges from persisting and causing UI/logic inconsistencies.
The
resetPreviewStatefunction previously did not cleartrimRanges,selectedRangeId, oractiveDrag. This allowed trim ranges from a previously loaded video to remain visible in the UI when a new, shorter video was loaded. These invalid ranges would then be silently filtered out during normalization, leading to a confusing "Add at least one trim range" error when the user attempted to process the video, despite seeing ranges in the UI.Note
Ensure trim UI state is fully reset on new video load.
resetPreviewStateto cleartrimRanges,selectedRangeId, andactiveDragalong with preview flagsWritten by Cursor Bugbot for commit 149ed09. This will update automatically on new commits. Configure here.