Graceful prompt exit#34
Merged
Merged
Conversation
Co-authored-by: me <me@kentcdodds.com>
Co-authored-by: me <me@kentcdodds.com>
|
Cursor Agent can help with this pull request. Just |
…ation Move handlePromptFailure from src/cli.ts and process-course/edits/cli.ts to cli-ux.ts to prevent maintenance issues and ensure consistent behavior across CLI entry points.
|
Bugbot Autofix resolved the bug found in the latest run.
|
|
🎉 This PR is included in version 1.13.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gracefully handle Ctrl+C during interactive prompts to prevent verbose stack traces.
This change maps Inquirer's
ExitPromptErrorto a customPromptCancellederror, which is then specifically handled by the yargs parser to exit cleanly without printing help messages or stack traces.Note
Improves interactive CLI robustness by cleanly handling prompt cancellations and yargs failures.
handlePromptFailure,isExitPromptError,handlePromptError, andrunPromptincli-ux.tsto map InquirerExitPromptErrortoPromptCancelledselect,search,input,confirm) withrunPromptto consistently translate cancellationssrc/cli.tsandprocess-course/edits/cli.tsto use.fail(handlePromptFailure)and.exitProcess(false)for clean exits without stack traces; keepsPromptCancelledhandling in top-level catchArgvWritten by Cursor Bugbot for commit df0c915. This will update automatically on new commits. Configure here.