Restore release environment for npm trusted publishing#12
Merged
Conversation
Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
productionenvironment on the publish-authorized release jobContext
The failing release run reached
@semantic-release/npmverification and npm rejected the OIDC exchange before falling back to an invalid placeholder token. The previous successful release workflow used theproductionenvironment, which is part of the npm trusted publishing identity when configured.The first branch push for this fix also showed the hardened workflow was requesting the
productionenvironment on feature branches. The release jobs now skip non-release branches while preservingmain, prerelease branches,next-major, and maintenance.xbranches.Testing
npm ci --ignore-scriptsnpm run test -- --runnpm run typechecknpm run buildgo run github.com/rhysd/actionlint/cmd/actionlint@latest .github/workflows/release.yml