-
Notifications
You must be signed in to change notification settings - Fork 1
Add ship-pr agent skill #78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+44
−0
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| --- | ||
| name: ship-pr | ||
| description: > | ||
| Babysit a PR. Iterate with AI reviewers and CI. Get it ready and maybe merge. | ||
| Send summary message. | ||
| --- | ||
|
|
||
| # Ship PR | ||
|
|
||
| ## Loop | ||
|
|
||
| 1. Mark ready — `kody:@kentcdodds/github-pr-tools/set-pr-review-status` with | ||
| `{ prUrl, status: 'ready' }`, or `{ owner, repo, prNumber, status: 'ready' }` | ||
| 2. Wait for CI — `gh pr checks` (compose `loop-on-ci`, `fix-ci`) | ||
| 3. Fix failures; address valid AI-reviewer feedback (ignore insignificant nits / | ||
| already-fixed / wrong) | ||
| 4. Green and no valid feedback left → break | ||
| 5. Push → repeat | ||
|
|
||
| ## Mode | ||
|
|
||
| By default, continue to Discord message with summary and include PR link | ||
|
|
||
| If explicitly requested, merge PR as Kody with | ||
| `kody:@kentcdodds/github-pr-tools/merge-pr` using | ||
| `{ prUrl, mergeMethod: 'squash' }` (or `{ owner, repo, prNumber, ... }`; | ||
| optional `commitTitle`), watch CI deploy, when finished, continue to the discord | ||
| message and include a summary with link to PR, deployed URL link, or failing job | ||
| link. | ||
|
|
||
| Other useful exports on the same package: `get-pr-checks` for check-run status | ||
| without `gh`, and `github-client` (`ghRestFetch` / `ghGraphQL`) for one-off | ||
| authenticated GitHub calls. | ||
|
|
||
| ## Done → Discord | ||
|
|
||
| ```javascript | ||
| import sendMeAMessage from 'kody:@kentcdodds/discord-gateway/send-me-a-message' | ||
|
|
||
| export default async function main() { | ||
| const content = ` ... ` | ||
| return sendMeAMessage({ content }) | ||
| } | ||
| ``` | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exit before reviews finish
Medium Severity
The loop waits only for CI in step 2, but step 4 exits when CI is green and there is no valid AI feedback. After a push, checks often finish before review comments or review checks land, so an agent can leave the loop and send Discord (or merge) while reviewer feedback is still pending.
Reviewed by Cursor Bugbot for commit b234db6. Configure here.