Skip to content

Add navigation progress bar#77

Draft
kentcdodds wants to merge 1 commit into
mainfrom
cursor/navigation-progress-bar-bcf6
Draft

Add navigation progress bar#77
kentcdodds wants to merge 1 commit into
mainfrom
cursor/navigation-progress-bar-bcf6

Conversation

@kentcdodds

Copy link
Copy Markdown
Member

Summary

  • Add Kody-style router lifecycle events: navigationstart and navigationend for loader-backed navigation, form POST redirect chains, programmatic navigation, and instant hash/popstate paths.
  • Add latest-wins abort semantics so superseded loader/form navigations do not emit stale completion events.
  • Mount a root-level NavigationProgress component with spin-delay timing, trickle progress, minimum visible duration, and fade-out.
  • Add E2E coverage that delays the chat route loader and verifies the progress bar appears and clears.

Walkthrough

navigation-progress-bar-demo.mp4

Testing

  • bun run typecheck
  • bun run lint
  • bun run test:unit
  • bun run build
  • bun tools/prepare-e2e-env.ts && bunx playwright test e2e/chat.spec.ts -g "navigation progress"
  • bun run test:e2e
  • Manual/headed browser walkthrough showing the top progress bar during delayed Chat route loading.
Open in Web Open in Cursor 

Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants