-
Notifications
You must be signed in to change notification settings - Fork 17
Use epicsTypes.h for conditions related to Base version #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
mdavidsaver
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like progress!
This reverts commit 477634c.
- fixes epics-modules#44 - follows M. Davidsaver's suggestions for the original fix
As of caPutLog R4.1, Base 3.14 is not supported (because caPutLog's use of epicsAtomic)
c7a7479 to
10f2a64
Compare
|
I notice another bit of weirdness. The |
|
Given that this was contractor work, one would wonder how thoroughly it was reviewed... |
|
I opened another ticket - see above. Hiding this union, which I support, would require review and changes in the CA Gateway interface to caPutLog. Needs coordinated PRs etc. etc. |
|
Or alternately, since this PR appears to remove base 3.14 support, adjust the yajl usage to work back to 3.15 and make JSON support unconditional. Also, I think it would be possible to restructure so that caPutJsonLogTest does not see |
As far as I can see, 3.14 support has been officially removed with R4.1, by using |
|
Superseded by #50 |
Following a suggestion from @mdavidsaver, here is a better fix for #44.