Skip to content

Conversation

@ralphlange
Copy link
Member

  • windows2019 -> windows 2022
  • macos-12 -> macos-latest
  • add RTEMS 5.1/686 qemu build

@simon-ess
Copy link
Contributor

The changes look good but the tests are failing 🫤

@ralphlange ralphlange force-pushed the fix-ci-builds branch 2 times, most recently from 2c2c659 to a041edb Compare November 24, 2025 09:14
- windows2019 -> windows 2022
- macos-12 -> macos-latest
- add RTEMS 5.1/686 qemu build
- fix job names to properly name artifacts
@ralphlange
Copy link
Member Author

This is why I was tagging it as "still in progress"...

@ralphlange ralphlange marked this pull request as ready for review November 24, 2025 09:34
@ralphlange
Copy link
Member Author

Here we go.

@ralphlange
Copy link
Member Author

"Hostname check"?
@simon-ess: Do you know what that means?

@simon-ess
Copy link
Contributor

Good question. The test that is failing is a bit suspicious: as I recall we wanted to confirm that the metadata from caputlog reported the hostname correctly; however, on mac os there was an issue with hostname casing. But I don't know why it is failing now...

I can try run the test locally and see what's up?

@ralphlange
Copy link
Member Author

    // Test hostname
    char hostname[1024];
    gethostname(hostname, 1024);

    // asLibRoutines changes the hostnames to lower-case; some OSs are not so kind.
    testOk(!epicsStrCaseCmp(hostname, jsonParser.host.c_str()),
            "%s - %s", testPrefix, "Hostname check");

I don't understand the aim of this test, and the comment is not helping.

@ralphlange
Copy link
Member Author

Anyway - the failure is not related to this PR.

@ralphlange
Copy link
Member Author

I don't understand the aim of this test, and the comment is not helping.

So caPutLog reports a hostname that is different from what gethostname() returns.
Too bad that neither of them is part of the test failure message.

@simon-ess
Copy link
Contributor

That's pretty fair; each of the tests in there suffers from the same problem. I'll create an issue.

@ralphlange
Copy link
Member Author

Note that the tests in my fork on the same commit (!!) passed.
https://github.com/ralphlange/caPutLog/actions/runs/19629101503

@simon-ess
Copy link
Contributor

Running the tests locally for me passes... 🙃

@ralphlange
Copy link
Member Author

ralphlange commented Nov 24, 2025

String length!
https://github.com/ralphlange/caPutLog/actions/runs/19634441236/job/56221652006

image

@ralphlange
Copy link
Member Author

Please merge this - the CI changes are fine, I think.

@simon-ess simon-ess merged commit 50032df into epics-modules:master Nov 24, 2025
10 of 12 checks passed
@ralphlange ralphlange deleted the fix-ci-builds branch November 24, 2025 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants