Skip to content

Security: Weak NodeID validation allows arbitrary identifier values #1103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tuanaiseo wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Security: Weak NodeID validation allows arbitrary identifier values #1103

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions discojs/src/client/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
export type NodeID = string

// TODO @s314cy: regexp test just like server-side
export function isNodeID (raw: unknown): raw is NodeID {
return typeof raw === 'string'
return typeof raw === 'string' && /^[a-zA-Z0-9_-]{1,64}$/.test(raw)
}