Conversation
|
It seems that this won't be merged soon, can you put your package to packagist @smskin ? |
|
Due to the long response, I had to recreate the PR to release the master branch. the master branch will be used to create a package in the packagist. @dchiorean @NoahNxT @TheSETJ @pitylee like pls the new request |
|
@smskin nice! But don't forget to update the documentation, because the composer require is not from epartment on your package. Maybe instead of creating a new package, did you consider sending him a mail to be a contributor? So many projects already use this version of nested form, it would be better that this package keeps maintained 😃 |
|
@NoahNxT Unfortunately, the author of the package does not respond to my messages. You are right, this package is used by a large number of developers. I would really like the authors to maintain their library. |
|
@smskin I'm currently not in any projects, sort of a timeout from developing anything IT related. Tell me what you need, I can give you access to maintain this package if you like, or anybody else who might be interested. This package, I believe, is still used for a bigger project I created. I'll have to ask if they still use this package (a specific modified branch), that's the only thing that needs to be left untouched. |
|
@smskin open-source has a lot of advantages but sadly in this case it can also be a disadvantage. Releasing this package under another name/organization isn't really ethical under open-source. I've really been thinking to take over an re-release it under my own name/organization but idk what to do... This is a package with a lit of potential and which solves a real pain of Nova. It would be sad if this would get lost between other unmaintained packages. |
|
@NoahNxT Then tell me what you need. If you know how to maintain packages everyone is free to join. |
@NoahNxT I completely agree with you. But unfortunately I couldn't wait for the bug fix any further |
|
@wize-wiz i'd like to be a maintainer as well, we use Nova a lot here and especially this package. We can easily support you and the team to get this package well maintained. |
@wize-wiz I can commit to maintaining this library. I use it in several projects. Or you can grant rights to @NoahNxT if he is willing to support it. Developers really need this library. I am very glad that after so many months of waiting, you have responded. I already thought that the community had lost this library. |
|
@wize-wiz awesome! |
|
@wize-wize I received and confirmed the invitation. Thank you for your trust! |
|
@smskin Yea just don't screw it up, haha kidding :D |
4 participants
Resolved conflicts of PR #146
Nova Nested Form is a useful package to create related resource inline using a cool UX.
This package has some problem if it contains a DependencyContainer field.
This PR allow these 2 packages to cooperate.
NestedForm uses a custom field syntax for nested purpose (based on PHP square bracket array syntax).
This PR change standard behavior of DependencyContainer to use this syntax if it used inside of a NestedForm.
It is obviously completely retro-compatible.
It fixes these PRs
yassilah/laravel-nova-nested-form#26
yassilah/laravel-nova-nested-form#114