Skip to content

Value is a parameter for dependsOn only #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dkulyk wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Value is a parameter for dependsOn only #162

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions src/NovaDependencyContainer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ public function dependsOn($field, $value)
{
return $this->withMeta([
'dependencies' => array_merge($this->meta['dependencies'], [
$this->getFieldLayout($field, $value)
array_merge($this->getFieldLayout($field), ['value' => $value])
])
]);
}
Expand Down Expand Up @@ -118,10 +118,9 @@ public function dependsOnNullOrZero($field)
* result in {field}.{field}, as it was in previous versions by default.
*
* @param $field
* @param $value
* @return array
*/
protected function getFieldLayout($field, $value = null)
protected function getFieldLayout($field)
{
if (count( ($field = explode('.', $field)) ) === 1) {
// backwards compatibility, property becomes field
Expand All @@ -132,8 +131,6 @@ protected function getFieldLayout($field, $value = null)
'field' => $field[0],
// property to compare
'property' => $field[1],
// value to compare
'value' => $value,
];
}

Expand Down